fix-dio-query-parameters #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jhomlala, Can you check this PR ? It's very important for us, else we can't use the official latest version |
|
@EArminjon can you fix your formatting? |
|
@techouse i didn't understand how the format can be wrong :
|
|
Yeah, it's weird. Locally all analyzer tests pass. Can you maybe re-run the action? |
techouse
approved these changes
Nov 10, 2024
|
Ah, I see. It's an unrelated file @EArminjon Can you please run |
EArminjon
force-pushed
the
fix-dio-query-parameters
branch
from
c8268d4
to
e904829
Compare
EArminjon
force-pushed
the
fix-dio-query-parameters
branch
from
e904829
to
c1574f9
Compare
|
In final, a rebase was just needed. OpenfileX used on my branch was the issue : they put a breaking change using 'patch' version instead of 'minor'. Thats lead to the issue above when running pub get. (A nullable string was converted to non nullable) |
techouse
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
options.queryParameters is used by Dio to offer an entrypoint for developpers to give query parameters easily.
options.queryParameters didn't contain queryParameters put inside path string :
uri.queryParameterscontain both (path.queryParameters and options.queryParameters). This PR fix that and this issue : #237